fast_gettext: Allow 4.x#155
Merged
bastelfreak merged 2 commits intomainfrom Aug 29, 2025
Merged
Conversation
Contributor
|
personally I would love to get rid of the dependencies :( |
bastelfreak
force-pushed
the
allow-latest-fast_gettext
branch
2 times, most recently
from
7e0117d to
e0e9851
Compare
smortex
force-pushed
the
allow-latest-fast_gettext
branch
from
e0e9851 to
159ba49
Compare
This is not enougth to update fast_gettext when using bundler because we depend on gettext-setup which in turn depends on fast_gettext ~> 2.1. But in the context of non-AIO install like we have on FreeBSD it allows us to get rid of local patches.
bastelfreak
force-pushed
the
allow-latest-fast_gettext
branch
from
159ba49 to
b990b4a
Compare
Newer version of fast_gettext do not overwrite the "new" behaviour of Ruby 1.9 String#% which raised exception when an invalid key was used. While here, rename the key to better match what they represent.
Member
Author
|
🎉 one less bug! |
bastelfreak
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not enougth to update fast_gettext when using bundler because we
depend on gettext-setup which in turn depends on fast_gettext ~> 2.1.
But in the context of non-AIO install like we have on FreeBSD it allows
us to get rid of local patches.