Skip to content

fix: puppet module install should honor manage_file_permissions=false#362

Merged
bastelfreak merged 1 commit intoOpenVoxProject:mainfrom
dotconfig404:fix/honor-manage-internal-file-permissions
Apr 9, 2026
Merged

fix: puppet module install should honor manage_file_permissions=false#362
bastelfreak merged 1 commit intoOpenVoxProject:mainfrom
dotconfig404:fix/honor-manage-internal-file-permissions

Conversation

@dotconfig404
Copy link
Copy Markdown
Contributor

@dotconfig404 dotconfig404 commented Mar 6, 2026

Hi!

puppet module install currently does not honor manage_internal_file_permissions.

In the module install path, Unpacker.harmonize_ownership always calls:

FileUtils.chown_R(source.stat.uid, source.stat.gid, target)

When running as non-root:

  • If target already has that UID/GID, this is effectively a no-op.
  • If ownership differs, it fails with Errno::EPERM (no CAP_CHOWN).

This causes problems when running openvoxserver with arbitrary UIDs, where code/data directories may be owned by a different UID than the runtime user.

Expected behavior: If manage_internal_file_permissions = false, skip ownership harmonization.

Thanks!

PS: This PR will remove the need for this

@bastelfreak bastelfreak added the bug Something isn't working label Apr 9, 2026
@bastelfreak
Copy link
Copy Markdown
Contributor

@bastelfreak
Copy link
Copy Markdown
Contributor

@dotconfig404 thanks for the fix!

@bastelfreak bastelfreak merged commit 7a946bf into OpenVoxProject:main Apr 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants