Skip to content

multi_json: Downgrade 1.20.1->1.19.1#156

Merged
bastelfreak merged 1 commit intomainfrom
multi_json
Apr 17, 2026
Merged

multi_json: Downgrade 1.20.1->1.19.1#156
bastelfreak merged 1 commit intomainfrom
multi_json

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

@bastelfreak bastelfreak commented Apr 17, 2026 •
edited
Loading

1.20.0 introduced a breaking change 🫠 sferik/multi_json@ca2c747

This was initially upgraded in 75960a1

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@bastelfreak bastelfreak self-assigned this Apr 17, 2026
@bastelfreak bastelfreak added the bug Something isn't working label Apr 17, 2026
@bastelfreak
multi_json: Downgrade 1.20.1->1.19.1
b444d1d 
1.20.0 introduced a breaking change 🫠
sferik/multi_json@ca2c747

This was initially upgraded in 75960a1

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
kengelhardt-godaddy
kengelhardt-godaddy approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@kengelhardt-godaddy kengelhardt-godaddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: already addressed

kengelhardt-godaddy
kengelhardt-godaddy approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@kengelhardt-godaddy kengelhardt-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bastelfreak
Copy link
Copy Markdown
Contributor Author

bastelfreak commented Apr 17, 2026

Oh I missed that picture :D

@bastelfreak bastelfreak merged commit 5ce4a36 into main Apr 17, 2026
41 checks passed
@bastelfreak bastelfreak deleted the multi_json branch April 17, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kengelhardt-godaddy kengelhardt-godaddy kengelhardt-godaddy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bastelfreak bastelfreak

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bastelfreak @kengelhardt-godaddy