Merged
Conversation
Contributor
Author
|
Testing consisted of a full build of |
Psych is a standard gem that is bundled with the Ruby installation and thus having a pinned version forces Bundler/RV to re-compile a new copy of something that is already present in the Ruby installation. This means extra CPU cycles spent running C compilers and extra dependencies on `-dev` packages to supply the required headers. Psych was pinned to `>= 4.0` in this commit to get consistent `YAML.safe_load` behavior in older Ruby versions used by build pipelines: puppetlabs/vanagon@463b0fb This `>= 4.0` requirement has been satisfied by the default gem set since the release of Ruby 3.1.0, the minimum allowed Ruby version is `>= 3.2` since OpenVoxProject/vanagon@4c4fe8a5, hence the original reason for the pin is now moot. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
bastelfreak
approved these changes
Apr 4, 2026
Contributor
|
we really need to get rubocop pinned or finally use voxpupuli-rubocop here :( |
Contributor
Author
|
I opened PR #82 with Rubocop fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psych is a standard gem that is bundled with the Ruby installation and
thus having a pinned version forces Bundler/RV to re-compile a new copy
of something that is already present in the Ruby installation. This means
extra CPU cycles spent running C compilers and extra dependencies on
-devpackages to supply the required headers.
Psych was pinned to
>= 4.0in this commit to get consistentYAML.safe_loadbehavior in older Ruby versions used by build pipelines:puppetlabs/vanagon@463b0fb
This
>= 4.0requirement has been satisfied by the default gem setsince the release of Ruby 3.1.0, the minimum allowed Ruby version is
>= 3.2since 4c4fe8a5, hence the originalreason for the pin is now moot.
Checklist
I have:
Signed-off-byannotation to each of my commits