Skip to content

[OXT-105] Fixed issues with certificate signing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossphilipson merged 1 commit into from
Mar 26, 2015
Merged

[OXT-105] Fixed issues with certificate signing #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions do_build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ Import-Module $ScriptDir\..\BuildSupport\checked-copy.psm1
#Get parameters
$args | Foreach-Object {$argtable = @{}} {if ($_ -Match "(.*)=(.*)") {$argtable[$matches[1]] = $matches[2];}}
$BuildType = $argtable["BuildType"]
$CertName = $argtable["CertName"]
$certname = $argtable["CertName"]
$codeVersion = $argtable["VerString"]
$CompanyName = $argtable["CompanyName"]
$MSBuild = $argtable["MSBuild"]
$signtool = $argtable["SignTool"]

$DoXenClientSign=''
if ($BuildType -eq "Release")
Expand All @@ -47,8 +48,8 @@ if ($BuildType -eq "Release")
}

# set a couple of environment variables to propagate to msbuild
$env:CERTNAME = $CertName
$env:SIGNTOOLPATH = $signtool+'\signtool.exe'
$env:CERTNAME = $certname
$env:SIGNTOOLPATH = ($signtool+"\signtool.exe")

#Set some important variables
$mywd = Split-Path -Parent $MyInvocation.MyCommand.Path
Expand Down Expand Up @@ -91,7 +92,7 @@ Set-Content .\common_properties.h
Pop-Location

#Build XenClientGuestService
Invoke-CommandChecked "Build XenClientGuestService" $MSBuild XenClientGuestService\XenClientGuestServiceVS2012.sln /p:Configuration=$BuildType /p:DoXenClientSign=$DoXenClientSign /p:CertName='\"'$Certname'\"' /p:TargetFrameworkVersion=v4.0 /m
Invoke-CommandChecked "Build XenClientGuestService" $MSBuild XenClientGuestService\XenClientGuestServiceVS2012.sln /p:Configuration=$BuildType /p:TargetFrameworkVersion=v4.0 /m

#Have to build XenClientGuestService MSMs before the other bits because it does the signing of DLLs as part of the MSBuild
#As building XenGuestPlugin rebuilds a few of these DLLs without signing it would break our install
Expand Down Expand Up @@ -122,9 +123,9 @@ Invoke-CommandChecked "XenGuestPlugin build" $MSBuild .\XenGuestPlugin\XenGuestP
#Sign XenGuestPlugin bits
if ($BuildType -eq "Release")
{
Invoke-CommandChecked "sign XenGuestAgent EXEs" signtool.exe sign /a /s my /n $CertName /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestAgent\$BuildType\*.exe
Invoke-CommandChecked "sign XenGuestPlugin DLLs" signtool.exe sign /a /s my /n $CertName /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestPlugin\XenGuestPlugin\bin\$BuildType\*.dll
Invoke-CommandChecked "sign XenGuestPlugin EXEs" signtool.exe sign /a /s my /n $CertName /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestPlugin\XenGuestPlugin\bin\$BuildType\*.exe
Invoke-CommandChecked "sign XenGuestAgent EXEs" ($signtool+"\signtool.exe") sign /a /s my /n ('"'+$certname+'"') /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestAgent\$BuildType\*.exe
Invoke-CommandChecked "sign XenGuestPlugin DLLs" ($signtool+"\signtool.exe") sign /a /s my /n ('"'+$certname+'"') /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestPlugin\XenGuestPlugin\bin\$BuildType\*.dll
Invoke-CommandChecked "sign XenGuestPlugin EXEs" ($signtool+"\signtool.exe") sign /a /s my /n ('"'+$certname+'"') /t http://timestamp.verisign.com/scripts/timestamp.dll XenGuestPlugin\XenGuestPlugin\bin\$BuildType\*.exe
}

#Build remaining MSMs
Expand Down