Error checking additions#104
Merged
jean-edouard merged 2 commits intoOpenXT:masterfrom Apr 23, 2019
Merged
Conversation
When lvcreate fails we should bubble the error up to the caller. During development, I had a huge debugging dom0 which left only 24MB free in the volume group after being written to /dev/xenclient/root.new. This wasn't enough for the 143MB upgrade-compat image, so its LV could not be created. The error was not caught, so execution continued until install-bootloader eventually failed and failed the OTA. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Use do_cmd so we have better insight into seal_system's operation. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Member
|
|
Member
|
Merging soon, for real now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are non-compat error checking additions from #103
We need create_lv to return an error when it cannot create an LV.
While touching the seal_system, prefix the seal commands with do_cmd so they are logged.