OXT-1654: Handle NVMe symlinks in /dev.#112
Merged
jean-edouard merged 2 commits intoOpenXT:masterfrom Jul 25, 2019
Merged
Conversation
added 2 commits
July 23, 2019 16:15
udev may create a symlink alias to the block device in /dev for some
NVMe drives.
get_devnode_{disk,partition} assumes they are passed the block device
path, but some utility tools (e.g, lvm-utils) can return the symlink
alias instead.
Add a sanitizing function to handle that.
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
OXT-1654
sanitize_devnode will follow the symlink alias and print the block device full path on stdout. Use the interface instead of local snippets. Signed-off-by: Eric Chanudet <chanudete@ainfosec.com> OXT-1654
crogers1
approved these changes
Jul 24, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
udev may create a symlink alias to the block device in /dev for some NVMe drives.
get_devnode_{disk,partition}assumes (per comment) they are passed the block devicepath, but some utility tools (e.g, lvm-utils) can return the symlink alias instead that end up being passed as argument.
Add a sanitizing function to avoid that.
part2 already has snippets doing just that when trying to remove any existing LVM setup cleaning. So use the new function instead.