[OXT-1640] Remove legacy falloc script#115
Merged
jean-edouard merged 1 commit intoOpenXT:masterfrom Aug 14, 2019
Merged
Conversation
jandryuk
approved these changes
Aug 9, 2019
Contributor
jandryuk
left a comment
jandryuk
left a comment
There was a problem hiding this comment.
LGTM
For completeness you should state that this depends on OpenXT/xenclient-oe#1228 to ensure they go in together.
eric-ch
reviewed
Aug 12, 2019
|
|
||
| # Reserve 4GB on storage | ||
| do_cmd falloc ${DOM0_MOUNT}/storage/xc-reserved 4096 >&2 || return 1 | ||
| do_cmd fallocate ${DOM0_MOUNT}/storage/xc-reserved -l 4096 >&2 || return 1 |
Contributor
There was a problem hiding this comment.
falloc size argument was in MB.
fallocate is in byte.
FALLOCATE(1)
[...]
-l, --length length
Specifies the length of the range, in bytes.
[...]
This commit replaces the custom OXT `falloc` command script with the standard `fallocate` call that gets pulled in by `util-linux`. [OXT-1640] Signed-off-by: Tim Konick <konickt@ainfosec.com>
Member
Member
|
Merging tomorrow. |
jean-edouard
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the custom OXT
falloccommand scriptwith the standard
fallocatecall that gets pulled in byutil-linux.Signed-off-by: Tim Konick konickt@ainfosec.com