OXT-796: xenmgr: Match multi-strings in dmi chassis type.#130
Merged
jean-edouard merged 1 commit intoOpenXT:masterfrom Nov 6, 2018
Merged
OXT-796: xenmgr: Match multi-strings in dmi chassis type.#130jean-edouard merged 1 commit intoOpenXT:masterfrom
jean-edouard merged 1 commit intoOpenXT:masterfrom
Conversation
dmidecode may return more than one type, e.g: root@e7470:~# dmidecode -s chassis-type Laptop Docking Station A docked laptop is still a laptop. Use a list of keywords and check every line for a match. Signed-off-by: Eric Chanudet <chanudete@ainfosec.com> OXT-796
Contributor
Author
|
v2:
|
Member
|
LGTM, please PR against stable-8 as well. |
Contributor
Author
|
Stable-8 PR: #131 |
Member
|
LGTM, merging soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmidecode may return more than one type, e.g:
A docked laptop is still a laptop.
Use a list of keywords and check every line for a match.