Remove xenmgr idle support#199
Merged
crogers1 merged 2 commits intoOpenXT:masterfrom Nov 9, 2023
Merged
Conversation
xenmgr is polling com.citrix.xenclient.input the "idle time" every 30 seconds. vGlass just returns 0 for this. There is a separate idle signal and xcpmd can use that to implement shutdown. Just remove this now unused code from xenmgr. A side effect of this removal is that xenmgr will no longer print errors from the failed DBus calls in console mode (runlevel 3). Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
xenmgr no longer acts on the idle time, xcpmd is supposed to handle that. This is no longer used and can be removed. However, the the UI still queries this. Make it just return 0 and drop writes. Later on the UI can remove the use and this can be removed here and from the IDL. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
crogers1
approved these changes
Feb 4, 2023
Contributor
crogers1
left a comment
crogers1
left a comment
There was a problem hiding this comment.
This LGTM. Merging later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xenmgr has a thread that polls vglass for idle time every 30 seconds. vglass hardcodes the response to 0, so it is ineffective. xcpmd has idle time support after #197 and OpenXT/xctools#74, so this loop can be removed.
The second commit makes the xenmgr config.ui properties hardcoded. The UI still has some code to query them. That could be removed with futher idl and toolstack-data clean ups. I didn't want to deal with the rebuild from changing the idl, so I didn't attempt that.
At least the first patch is nice since it removes pointless polling and eliminates log spam in console mode (runlevel 3).