S9: OXT-1622: surfman: xc_domain_getinfo usage.#33
Merged
jean-edouard merged 1 commit intoOpenXT:stable-9from Jul 30, 2019
Merged
S9: OXT-1622: surfman: xc_domain_getinfo usage.#33jean-edouard merged 1 commit intoOpenXT:stable-9from
jean-edouard merged 1 commit intoOpenXT:stable-9from
Conversation
xc_domain_getinfo(h, domid, n, info): will return the number of xc_dominfo_t written in info and fill info starting with the first domain with domain_id >= domid. In practice, this means, xc_domain_getinfo(h, domid, 1, info), may fill the info struct for a domain which domain_id != domid. This is a problem for xc_domid_exists() which makes that assumption. Since libsurfman provides xc_domid_getinfo() handle the case in it and use the exported function across surfman. The main in this is xc_domid_getinfo() will return -ENOENT if the domain associated with the domid in argument does not exist. Signed-off-by: Eric Chanudet <chanudete@ainfosec.com> (cherry picked from commit 64793ff) Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
Member
Member
|
Merging soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xc_domain_getinfo(h, domid, n, info): will return the number ofxc_dominfo_twritten in info and fill info starting with the first domain withdomain_id >= domid.In practice, this means,
xc_domain_getinfo(h, domid, 1, info), may fill the info struct for a domain whichdomain_id != domid. This is a problem forxc_domid_exists()which makes that assumption.Since libsurfman provides
xc_domid_getinfo()handle the case in it and use the exported function across surfman.xc_domid_getinfo()will return -ENOENT if the domain associated with the domid in argument does not exist.This was merged in master with #25.