Clean up destruction of domains with PCI devices.#10
Merged
rossphilipson merged 2 commits intoOpenXT:masterfrom Jul 31, 2015
Merged
Clean up destruction of domains with PCI devices.#10rossphilipson merged 2 commits intoOpenXT:masterfrom
rossphilipson merged 2 commits intoOpenXT:masterfrom
Conversation
added 2 commits
July 30, 2015 16:44
This commit makes two slight modifications to domain destruction:
- PCI device resets ("FLRs") are deferred until all devices have
been detached from the target domain. This enables resets to go
through even for multi-function devices that require an SBR, as
all of their functions will be released when the reset occurs.
- Domain destruction is deferred until all of the PCI devices are
detached. This cleans up a fair number of Xen error messages,
and ensures that all PCI-tracking metadata is freed in the
hypervisor. (Earlier, the domains were destroyed /before/ their
devices were freed-- resulting in Xen losing its references to
the PCI device data. The later request to free failed, as Xen
didn't recognize the domid.)
OXT-343
OXT-343 Signed-off-by: Kyle J. Temkin <temkink@ainfosec.com>
Contributor
|
Tested, screen always properly blanked. Merging. |
rossphilipson
added a commit
that referenced
this pull request
Jul 31, 2015
Clean up destruction of domains with PCI devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two slight modifications to domain destruction:
been detached from the target domain. This enables resets to go
through even for multi-function devices that require an SBR, as
all of their functions will be released when the reset occurs.
detached. This cleans up a fair number of Xen error messages,
and ensures that all PCI-tracking metadata is freed in the
hypervisor. (Earlier, the domains were destroyed /before/ their
devices were freed-- resulting in Xen losing its references to
the PCI device data. The later request to free failed, as Xen
didn't recognize the domid.)