Skip to content

toolstack: Pass -fPIC to CFLAGS.#34

Merged
jean-edouard merged 2 commits intoOpenXT:masterfrom
eric-ch:qa-warnings-1
Apr 3, 2018
Merged

toolstack: Pass -fPIC to CFLAGS.#34
jean-edouard merged 2 commits intoOpenXT:masterfrom
eric-ch:qa-warnings-1

Conversation

@eric-ch
Copy link
Copy Markdown
Contributor

@eric-ch eric-ch commented Mar 29, 2018

Was reported by bitbake:

WARNING: xenclient-toolstack-0+gitAUTOINC+b22cf03e5a-r0 do_package_qa: QA Issue: ELF binary '/home/build/openxt/pyro-2/tmp-glibc/work/xenclient_dom0-oe-linux/xenclient-toolstack/0+gitAUTOINC+b22cf03e5a-r0/packages-split/xenclient-toolstack-libs/usr/lib/ocaml/site-lib/stdext/dllstdext_stubs.so' has relocations in .text
ELF binary '/home/build/openxt/pyro-2/tmp-glibc/work/xenclient_dom0-oe-linux/xenclient-toolstack/0+gitAUTOINC+b22cf03e5a-r0/packages-split/xenclient-toolstack-libs/usr/lib/ocaml/site-lib/log/dllsyslog_stubs.so' has relocations in .text [textrel]

Eric Chanudet added 2 commits March 28, 2018 18:10
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
Avoid textrel at all cost.
Pass -fPIC if it is not already.

Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
@jean-edouard
Copy link
Copy Markdown
Member

@jean-edouard
Copy link
Copy Markdown
Member

LGTM, merging soon.

@jean-edouard jean-edouard merged commit a5ca565 into OpenXT:master Apr 3, 2018
@eric-ch eric-ch deleted the qa-warnings-1 branch May 8, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants