Skip to content

STABLE-8: toolstack: Pass -fPIC to CFLAGS#36

Merged
jean-edouard merged 2 commits intoOpenXT:stable-8from
eric-ch:stable-8-qa-warnings-1
Apr 3, 2018
Merged

STABLE-8: toolstack: Pass -fPIC to CFLAGS#36
jean-edouard merged 2 commits intoOpenXT:stable-8from
eric-ch:stable-8-qa-warnings-1

Conversation

@eric-ch
Copy link
Copy Markdown
Contributor

@eric-ch eric-ch commented Mar 30, 2018

Was reported by bitbake:

WARNING: xenclient-toolstack-0+gitAUTOINC+b22cf03e5a-r0 do_package_qa: QA Issue: ELF binary '/home/build/openxt/pyro-2/tmp-glibc/work/xenclient_dom0-oe-linux/xenclient-toolstack/0+gitAUTOINC+b22cf03e5a-r0/packages-split/xenclient-toolstack-libs/usr/lib/ocaml/site-lib/stdext/dllstdext_stubs.so' has relocations in .text
ELF binary '/home/build/openxt/pyro-2/tmp-glibc/work/xenclient_dom0-oe-linux/xenclient-toolstack/0+gitAUTOINC+b22cf03e5a-r0/packages-split/xenclient-toolstack-libs/usr/lib/ocaml/site-lib/log/dllsyslog_stubs.so' has relocations in .text [textrel]

Eric Chanudet added 2 commits March 30, 2018 18:09
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
(cherry picked from commit 57298e9)
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
Avoid textrel at all cost.
Pass -fPIC if it is not already.

Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
(cherry picked from commit a262e25)
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
@eric-ch
Copy link
Copy Markdown
Contributor Author

eric-ch commented Apr 2, 2018

Building $1442

@jean-edouard
Copy link
Copy Markdown
Member

LGTM, merging soon.

@jean-edouard jean-edouard merged commit 7702618 into OpenXT:stable-8 Apr 3, 2018
@eric-ch eric-ch deleted the stable-8-qa-warnings-1 branch May 8, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants