[xcpmd] Bring back missing quirk check for Dell brightness keys#19
Merged
rossphilipson merged 1 commit intoOpenXT:masterfrom Dec 7, 2015
jctemkin:brightness-quirk
Merged
[xcpmd] Bring back missing quirk check for Dell brightness keys#19rossphilipson merged 1 commit intoOpenXT:masterfrom jctemkin:brightness-quirk
rossphilipson merged 1 commit intoOpenXT:masterfrom
jctemkin:brightness-quirk
Conversation
Contributor
|
I am going through history trying to see where it got lost and I am getting lost. Where was that code originally? |
Contributor
|
@jean-edouard found it in xcpmd.c. The code changed a lot so it was not obvious. Anyway +1, those systems need the SW assisted brightness control. |
Contributor
|
This does not compile: |
Author
|
I appear to be ham-handed this afternoon. Fixed. |
Contributor
|
Tested, works, will merge soon... |
rossphilipson
added a commit
that referenced
this pull request
Dec 7, 2015
[xcpmd] Bring back missing quirk check for Dell brightness keys
jean-edouard
added a commit
to jean-edouard/xctools
that referenced
this pull request
Oct 29, 2019
[cleanup] Remove transfer manager unused interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for this quirk got lost when I was refactoring. This should fix OXT-405 for the Dell platforms in question--I don't have a 7440/7450, but it works on the 6330 I have here.