fix(XSPerfAccumulate): fix compilation error from #140#142
Merged
Conversation
```
Error: [697] [error] /nfs/home/cirunner/ci-runner-xs/xs-builder-node030-2/_work/XiangShan/XiangShan/utility/src/main/scala/utility/PerfCounterUtils.scala:59:8: in object XSPerfAccumulate, multiple overloaded alternatives of method apply define default arguments.
Error: [697] [error] object XSPerfAccumulate extends HasRegularPerfName with XSLogTap {
Error: [697] [error] ^
Error: [697] [error] one error found
```
scala does not allow overload with default argument, not sure why this works before.
Also merge XSPerfPriorityAccumulate to XSPerfSeqAccumulate as a parameter `withPriority`
Signed-off-by: ngc7331 <ngc7331@outlook.com>
Yan-Muzi
approved these changes
Mar 30, 2026
ngc7331
added a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 30, 2026
to fix compilation error See: - OpenXiangShan/Utility#142 - https://github.com/OpenXiangShan/XiangShan/actions/runs/23642516962/job/68866471360 Signed-off-by: ngc7331 <ngc7331@outlook.com>
rich-cake
pushed a commit
to OpenXiangShan/XiangShan
that referenced
this pull request
Mar 30, 2026
to fix compilation error See: - OpenXiangShan/Utility#140 - OpenXiangShan/Utility#142 - https://github.com/OpenXiangShan/XiangShan/actions/runs/23642516962/job/68866471360 Also includes: - OpenXiangShan/Utility#139 - OpenXiangShan/Utility#141 Signed-off-by: ngc7331 <ngc7331@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scala does not allow overload with default argument, not sure why this works before.
Also merge XSPerfPriorityAccumulate to XSPerfSeqAccumulate as a parameter
withPriority