Options path fixes #82
Merged
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks |
Member
|
Please launch tests befor sunbmiting PR. Thanks |
Contributor
Author
|
The tests completed successfully for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the calculated config_path for ZWaveOption wasn't available on the config_path property. These lines worked correctly when a config/user path was passed in, but end up with the wrong value if config_path needs to be calculated by PyOptions. I changed the PyOptions variables to be readable by the parent class, so the properties can be exposed to the API.
I also eliminated the duplication of default values, since the final values will now be correctly passed back up to the parent.