sync::from_latest and latest Modes Should Return Notification::NoPastLogsFound Instead Of Empty Vec #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b1718ad.
0xNeshi
changed the title
LeoPatOZ
reviewed
Nov 21, 2025
Comment on lines
+123
to
+132
| if collected.is_empty() { | ||
| info!("No logs found"); | ||
| _ = sender.try_stream(Notification::NoPastLogsFound).await; | ||
| } else { | ||
| info!(count = collected.len(), "Logs found"); | ||
| collected.reverse(); // restore chronological order | ||
| } | ||
|
|
||
| info!("Sending collected logs to consumer"); | ||
| _ = sender.try_stream(collected).await; | ||
| info!("Sending collected logs to consumer"); | ||
| _ = sender.try_stream(collected).await; | ||
| } |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| if collected.is_empty() { | |
| info!("No logs found"); | |
| _ = sender.try_stream(Notification::NoPastLogsFound).await; | |
| } else { | |
| info!(count = collected.len(), "Logs found"); | |
| collected.reverse(); // restore chronological order | |
| } | |
| info!("Sending collected logs to consumer"); | |
| _ = sender.try_stream(collected).await; | |
| info!("Sending collected logs to consumer"); | |
| _ = sender.try_stream(collected).await; | |
| } | |
| if collected.is_empty() { | |
| info!("No logs found"); | |
| _ = sender.try_stream(Notification::NoPastLogsFound).await; | |
| break; | |
| } | |
| info!(count = collected.len(), "Logs found"); | |
| collected.reverse(); // restore chronological order | |
| info!("Sending collected logs to consumer"); | |
| _ = sender.try_stream(collected).await; | |
| } |
LeoPatOZ
reviewed
Nov 21, 2025
| #[derive(Debug, Clone)] | ||
| /// Messages streamed by the scanner to subscribers. | ||
| /// | ||
| /// Each message represents either data (logs), an error, or a notification about the scanner's |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| /// Each message represents either data (logs), an error, or a notification about the scanner's | |
| /// Each message represents either data or a notification about the scanner's |
No more error :D
Also not always logs?
LeoPatOZ
reviewed
Nov 21, 2025
Comment on lines
+14
to
+17
| /// Data streamed to the subscriber. | ||
| Data(T), | ||
|
|
||
| /// Notification about scanner state changes or important events. |
Collaborator
There was a problem hiding this comment.
nit: Also wonder how useful these are
Data is self explanatory and Notification comment is the same above the notification enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #180
Towards #50 - added missing from/to block validation to
latestmode