Skip to content

Support Drillneck special modifier.#837

Merged
Openarl merged 1 commit intoOpenarl:devfrom
temmings:dev-can-parse-drillneck
May 29, 2018
Merged

Support Drillneck special modifier.#837
Openarl merged 1 commit intoOpenarl:devfrom
temmings:dev-can-parse-drillneck

Conversation

@temmings
Copy link
Copy Markdown
Contributor

@temmings temmings commented Feb 21, 2018

Hi. PoB is a very useful tool. I always have fun. :)

  • Can parse Arrows deal 50% increased Damage with Hits and Ailments to Targets they Pierce
  • Remove special mod from specialModList
  • Fix unique item Drillneck special modifier

Background

  1. PoB 1.4.74 Uniques Drillneck modifier was incorrect
  2. Actually imported from the game
    • Arrows deal 50% increased Damage with Hits and Ailments to Targets they Pierce
    • PoB 1.4.74 can't parse this

Test

Build data for test: https://pastebin.com/856uV0gb

  • Include item: PoB 1.4.74 Uniques Drillneck (can parse / backward compatibility)
  • Include item: Actually modifier Drillneck (can parse)

@temmings
Copy link
Copy Markdown
Contributor Author

temmings commented Mar 3, 2018

Conflict resolved.
Rebase to 0eea108
Rebase to 5bdfafd
Issue #929

@temmings temmings force-pushed the dev-can-parse-drillneck branch 2 times, most recently from c42ea9d to 02f63a6 Compare March 3, 2018 13:34
@temmings temmings force-pushed the dev-can-parse-drillneck branch from 02f63a6 to dd7fdb9 Compare March 22, 2018 13:20
- Can parse `Arrows deal 50% increased Damage with Hits and Ailments to
Targets they Pierce`
- Remove special mod from `specialModList`
- Fix unique item Drillneck special modifier
  - https://pathofexile.gamepedia.com/Drillneck
@temmings temmings force-pushed the dev-can-parse-drillneck branch from dd7fdb9 to ea6b64e Compare March 28, 2018 13:55
@jcmoyer
Copy link
Copy Markdown

jcmoyer commented May 9, 2018

Any updates on this? It's still broken in 1.4.86.

Currently I work around the issue by manually editing the drillneck every time I do a complete re-import.

@temmings temmings closed this May 11, 2018
@temmings
Copy link
Copy Markdown
Contributor Author

Probably he is busy, I think he can not afford to confirm the PR.
I will close PR to concentrate on his development.

@Openarl Openarl reopened this May 29, 2018
@Openarl Openarl merged commit d03452b into Openarl:dev May 29, 2018
@Openarl
Copy link
Copy Markdown
Owner

Openarl commented May 29, 2018

Well, it is about time this was fixed! I may need to tweak the tags, though.

@temmings temmings deleted the dev-can-parse-drillneck branch February 28, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants