Skip to content

Conversation

@potench
Copy link

@potench potench commented Sep 15, 2020

background

  • add check for Promise.finally in loader.js / affects older IE Edge < = 17
  • add more data to localization error. Seeing a lot of Access-Control errors and other related errors.

test plan

  1. Verify site does not load polyfills in Chrome. [x]
  2. Verify site does load polyfills based on "finally" check in Edge 17. [x]

followup plan

  1. review error logs for localizeError to investigate source of occasional "Access-Control-All" and "Unexpected token <" errors.

@potench potench merged commit 9c780d6 into master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants