Show the save button by default on the CMP banner #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potench
reviewed
Sep 29, 2021
src/s1/lib/store.js
Outdated
| manualVendorConsents = new Set(); // vendor-consent management partially automatic and partially manual depending on the consent screen | ||
| isModalShowing = false; | ||
| isSaveShowing = false; | ||
| isSaveShowing = true; |
There was a problem hiding this comment.
Hmm I would probably create a new config.shouldAlwaysShowSave feature toggle, default it to false and pass it in to allow overriding this behavior.
Ideally we only want the "save" button visible when a user has purposefuly interacted to set their consent. Otherwise, "Save" receives the same UI priority as "Ok, Got it" and users will be very likely to just "Save" with no consent granted.
It makes sense to offer a feature that enables "Save" with the same priority as "Ok Got it" (ie, it makes sense to want to be able to offer "Save" consistently), but I would not bake that feature in, and instead I would provide a config to allow turning the feature on as optional.
potench
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the system1 CMP currently, where it is not obvious how a user opts out.
The "ok, got it" button is an accept all button, and the save button, which saves the current consent state, does not show up by default until a uesr interact with one of the switch.