fix: prevent value overflow in KeyValueGrid#340
fix: prevent value overflow in KeyValueGrid#340egeoztass wants to merge 1 commit intoOpenpanel-dev:mainfrom
Conversation
Long values in the KeyValueGrid were overflowing into the key column. Added min-w-0 and max-w-[60%] to the value container so truncation works correctly within the flex layout. Closes Openpanel-dev#305 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single CSS class modification in the KeyValueGrid value cell adds width constraints ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
KeyValueGrid(Minor UI issue for KeyValueGrid #305)min-w-0andmax-w-[60%]to the value container sotruncateworks correctly within the flex layoutBefore
Values that are too long push into the key column, breaking the layout.
Fix
Single line change in
apps/start/src/components/ui/key-value-grid.tsx:min-w-0allows the flex child to shrink below its content sizemax-w-[60%]ensures the value never takes more than 60% of the row widthtruncateclass then clips with ellipsis as expectedTest plan
KeyValueGrid(event details, session details, profile properties)titleattributeCloses #305
🤖 Generated with Claude Code
Summary by CodeRabbit