feat(protocol-designer): add to list of bugs addressed for PD 8.5 so far #18169
Conversation
jerader
requested review from
ecormany and
emilyburghardt
and removed request for
a team
protocol-designer/release-notes.md
Outdated
| ### Bug Fixes | ||
|
|
||
| - Transfer step details show correct aspirate and dispense volumes when distributing liquid (a single aspirate and multiple dispenses). | ||
| - While mixing, the pipette no longer lifts between mixes due to a newly created customizable push out field. |
There was a problem hiding this comment.
i guess we should specify that by default, the push out is set to 0 now for a mix step but the field is also customizable if they want to change it to something else
There was a problem hiding this comment.
I believe the default is pushout=0 for all but the last dispense in the mix?
There was a problem hiding this comment.
Yep, I probably wrote this and it's confusing as written! Let's fix it.
During a mix, push_out=0 by default to avoid multiple push out actions. You can choose your own push out volume in a mix step menu.
*I'm assuming here that the push out is now customizable in the mix step menu. Not going to specify a max or min value since PD does that for you if you enter a value outside the acceptable range.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18169 +/- ##
==========================================
+ Coverage 24.99% 25.40% +0.41%
==========================================
Files 3026 3038 +12
Lines 235167 256614 +21447
Branches 20168 25253 +5085
==========================================
+ Hits 58775 65192 +6417
- Misses 176378 191408 +15030
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| - When uploading a protocol and the drop tip location is unknown, users can now manually select the new location from the Drop Tip Location dropdown. | ||
| - Correctly migrate adapter/labware combo definitions into their singular definitions when uploading a protocol that is older than version 7.0.0. | ||
| - When adding a disposal volume, a blow out location is now required. | ||
|
|
There was a problem hiding this comment.
I'm trying to remember: was there some customer issue from March about us dropping or not dropping tips in some cases, that we fixed?
There was a problem hiding this comment.
I don't think so? this bullet point is referring to the most recent fix that Nick made to address the bug that you were investigating.
emilyburghardt
left a comment
emilyburghardt
left a comment
There was a problem hiding this comment.
Left a few text suggestions!
protocol-designer/release-notes.md
Outdated
| ### Improved Features | ||
|
|
||
| - Protocol Designer includes a warning when you clear a slot with labware, a module, or a fixture used in a protocol step. | ||
| - More robust validation when uploading custom labware. |
There was a problem hiding this comment.
maybe we could make this a bit more specific , or even just worded differently to seem more specific, like:
"Protocol Designer takes extra steps to validate any custom labware you upload."
and if we can think of an example, "PD takes extra steps, like....to validate..."
There was a problem hiding this comment.
Ah this is in relation to how AI was generating custom labwares that were wrong but still passed our previous validation logic. So to fix that, we added some additional testing to make sure the custom def is actually correct
protocol-designer/release-notes.md
Outdated
| - While mixing, the pipette no longer lifts between mixes due to a newly created customizable push out field. | ||
| - When uploading a protocol and the drop tip location is unknown, users can now manually select the new location from the Drop Tip Location dropdown. | ||
| - Correctly migrate adapter/labware combo definitions into their singular definitions when uploading a protocol that is older than version 7.0.0. | ||
| - When adding a disposal volume, a blow out location is now required. |
There was a problem hiding this comment.
Adding a few text suggestions to reword these:
-
Choose a new tip drop location from the dropdown menu when an uploaded protocol is missing a drop tip location.
-
Protocol Designer correctly updates adapter and labware combination definitions when you upload a protocol designed in Protocol Designer v7.0.0 or earlier. (could still use "migrate" here if we want)
ecormany
left a comment
ecormany
left a comment
There was a problem hiding this comment.
Few little comments (including one bit of text that definitely has to come out). Thanks all for working on this!
protocol-designer/release-notes.md
Outdated
| - Transfer step details show correct aspirate and dispense volumes when distributing liquid (a single aspirate and multiple dispenses). | ||
| - During a mix, `push_out=0` by default for all mixes except for the last, to avoid multiple push out actions. You can choose your own push out volume in a mix step menu. | ||
| - Choose a new tip drop location from the dropdown menu when an uploaded protocol is missing a drop tip location. | ||
| - Protocol Designer correctly updates adapter and labware combination definitions when you upload a protocol designed in Protocol Designer v7.0.0 or earlier. (could still use "migrate" here if we want) |
There was a problem hiding this comment.
| - Protocol Designer correctly updates adapter and labware combination definitions when you upload a protocol designed in Protocol Designer v7.0.0 or earlier. (could still use "migrate" here if we want) | |
| - Protocol Designer correctly updates adapter and labware combination definitions when you upload a protocol designed in Protocol Designer v7.0.0 or earlier. |
😇
There was a problem hiding this comment.
oops, classic example of me not ready the text and just blindly copy and pasting 😆
protocol-designer/release-notes.md
Outdated
| ### Bug Fixes | ||
|
|
||
| - Transfer step details show correct aspirate and dispense volumes when distributing liquid (a single aspirate and multiple dispenses). | ||
| - During a mix, `push_out=0` by default for all mixes except for the last, to avoid multiple push out actions. You can choose your own push out volume in a mix step menu. |
There was a problem hiding this comment.
No code formatting, since PD is a no-code tool.
| - During a mix, `push_out=0` by default for all mixes except for the last, to avoid multiple push out actions. You can choose your own push out volume in a mix step menu. | |
| - During a mix, push out is set to 0 by default for all mixes except for the last, to avoid multiple push out actions. You can choose your own push out volume in a mix step menu. |
protocol-designer/release-notes.md
Outdated
| - During a mix, `push_out=0` by default for all mixes except for the last, to avoid multiple push out actions. You can choose your own push out volume in a mix step menu. | ||
| - Choose a new tip drop location from the dropdown menu when an uploaded protocol is missing a drop tip location. | ||
| - Protocol Designer correctly updates adapter and labware combination definitions when you upload a protocol designed in Protocol Designer v7.0.0 or earlier. (could still use "migrate" here if we want) | ||
| - When adding a disposal volume, a blow out location is now required. |
There was a problem hiding this comment.
noun 🧐
| - When adding a disposal volume, a blow out location is now required. | |
| - When adding a disposal volume, a blowout location is now required. |
ecormany
left a comment
ecormany
left a comment
There was a problem hiding this comment.
Copy updates look good!
Overview
Add list of bugs that have been addressed in edge over the past few months that will be out with the PD 8.5 release
Escalation bug tickets that are addressed: https://opentrons.atlassian.net/jira/servicedesk/projects/RESC/queues/custom/240/RESC-431, https://opentrons.atlassian.net/jira/servicedesk/projects/RESC/queues/custom/240/RESC-422, https://opentrons.atlassian.net/jira/servicedesk/projects/RESC/queues/custom/240/RESC-397,
https://opentrons.atlassian.net/jira/servicedesk/projects/RESC/queues/custom/240/RESC-383
and also this bug in slack
Test Plan and Hands on Testing
review copy
Changelog
Review requests
Risk assessment
low