Skip to content

Conversation

@ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented Apr 25, 2025

Overview

Due to the way that the movement logic of blow out is handled, it expects an absolute point. So when a location is a meniscus relative type, then it miscalculates the "delta" of the point. The delta it computes is -1 * the absolute point of the well.top.

To correct this if the location passed into blowout is a meniscus relative location, we take the offset from that and apply it to the current well height instead. this gives us the correct absolute point.

The other option would have been to hook up all the layers to handle LiquidHandlingWellLocation types in addition to WellLocation but that has its own headaches since its not actually liquid handling, and there is no operational volume.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Using blowout with a meniscus relative location without a liquid-probe or load liquid will now fail analysis. there is no interaction with a "minimum liquid height" so there is no worries there. even with a liquid height of 0

@ryanthecoder ryanthecoder requested a review from a team as a code owner April 25, 2025 19:20
@ryanthecoder ryanthecoder force-pushed the RABR-763-blowout-with-meniscus-target branch from a888d69 to f7e2b65 Compare April 25, 2025 19:21
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test, and also if this is a thing that can fail if there's an invalid volume we should note it down somewhere that the command will fail unrecoverably if the volume is invalid

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryanthecoder ryanthecoder merged commit 7b5c092 into chore_release-8.4.0 Apr 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants