fix(api): correct the behavior of blowout when using a .meniscus target #18185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Due to the way that the movement logic of blow out is handled, it expects an absolute point. So when a location is a meniscus relative type, then it miscalculates the "delta" of the point. The delta it computes is -1 * the absolute point of the well.top.
To correct this if the location passed into blowout is a meniscus relative location, we take the offset from that and apply it to the current well height instead. this gives us the correct absolute point.
The other option would have been to hook up all the layers to handle LiquidHandlingWellLocation types in addition to WellLocation but that has its own headaches since its not actually liquid handling, and there is no operational volume.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Using blowout with a meniscus relative location without a liquid-probe or load liquid will now fail analysis. there is no interaction with a "minimum liquid height" so there is no worries there. even with a liquid height of 0