fix(app): fix labware displayed on modules during LPC #18204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
a team and
ncdiehl11
and removed request for
a team and
ncdiehl11
sfoster1
approved these changes
Apr 29, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
that's a very happy kind of fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-4156
Overview
When LPCing a labware in a module slot, the "Prepare deck for LPC" view's deck map currently renders the actively LPC'd labware above all modules and not just the module of interest.
To fix, we only render the LPC'd labware above the module with an id that matches the location-specific module id.
Current Behavior
Fixed Behavior
Test Plan and Hands on Testing
Changelog
Risk assessment
very low