fix(protocol-designer): get all labware defs instead of latest when z… #18223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ooming into slot
closes AUTH-1730
Overview
NOTE: cherry-picked from the edge commit
As documented in the ticket, there was a white screen if you upload a protocol to PD that has an older labware definition version and then try to zoom into that slot. The error specifically occurred with the highlight overlay that shows the labware display name.
This PR fixes it by refactoring the component to return all labware definitions instead of just latest. This does not affect selecting new labware though, that utility just returns the latest versions - this prevents users from selecting older versions with new steps/new deck setups
Test Plan and Hands on Testing
Upload the attached protocol and zoom into the thermocycler slot or the 1 well reservoir slot. See that it does not white screen.
Note that it looks like the labware selected isn't selected in the labware toolbox but that is because it is showing only latest defs. i think that is fine. the user will be regenerating their labware anyway if they make any changes
doItAllV8 (29).json
Changelog
Risk assessment
low, doesn't touch much code