Skip to content

Conversation

@jerader
Copy link
Collaborator

@jerader jerader commented May 1, 2025

…ooming into slot

closes AUTH-1730

Overview

NOTE: cherry-picked from the edge commit

As documented in the ticket, there was a white screen if you upload a protocol to PD that has an older labware definition version and then try to zoom into that slot. The error specifically occurred with the highlight overlay that shows the labware display name.

This PR fixes it by refactoring the component to return all labware definitions instead of just latest. This does not affect selecting new labware though, that utility just returns the latest versions - this prevents users from selecting older versions with new steps/new deck setups

Test Plan and Hands on Testing

Upload the attached protocol and zoom into the thermocycler slot or the 1 well reservoir slot. See that it does not white screen.

Note that it looks like the labware selected isn't selected in the labware toolbox but that is because it is showing only latest defs. i think that is fine. the user will be regenerating their labware anyway if they make any changes

doItAllV8 (29).json

Changelog

  • get all defs instead of latest defs
  • fix test

Risk assessment

low, doesn't touch much code

@jerader jerader requested a review from a team as a code owner May 1, 2025 14:48
@jerader jerader requested review from koji and ncdiehl11 May 1, 2025 14:50
@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.49%. Comparing base (3f8243d) to head (58f83a3).
Report is 3 commits behind head on chore_release-pd-8.4.4.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.4.4   #18223      +/-   ##
==========================================================
+ Coverage                   21.46%   21.49%   +0.02%     
==========================================================
  Files                        2748     2748              
  Lines                      212336   212336              
  Branches                     7224     7239      +15     
==========================================================
+ Hits                        45586    45635      +49     
+ Misses                     166743   166694      -49     
  Partials                        7        7              
Flag Coverage Δ
protocol-designer 18.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pages/Designer/DeckSetup/SelectedHoveredItems.tsx 95.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jerader jerader merged commit 3494d89 into chore_release-pd-8.4.4 May 1, 2025
16 checks passed
@jerader jerader deleted the pd_all-defs branch May 1, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants