-
Notifications
You must be signed in to change notification settings - Fork 189
feat(components, app): add InlineNotification component for instrument/module card
#18371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18371 +/- ##
==========================================
- Coverage 57.85% 57.79% -0.07%
==========================================
Files 3252 3252
Lines 276196 276158 -38
Branches 32255 32194 -61
==========================================
- Hits 159799 159595 -204
- Misses 116204 116370 +166
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
components/src/atoms/InlineNotification/MiniInlineNotification.tsx
Outdated
Show resolved
Hide resolved
|
@ahiuchingau @smb2268 cc: @jerader |
fe034c3 to
a353a69
Compare
MiniInlineNotification component for instrument/module cardInlineNotification component for instrument/module card
31ce8f6 to
f734eca
Compare
vegano1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end, tested with flex
| return ( | ||
| <Flex | ||
| className={className} | ||
| transform={mount === 'right' ? 'scaleX(-1)' : ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this was meant to rotate the pipette image to the proper orientation - is this not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property has been overwritten by other transform props that get passed down to InsturmentDiagram so the images actually never get flipped – so i removed it
smb2268
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY
…instrument/module card (#18371)
Overview
InlineNotificationcomponentTest Plan
Module setup requiredbanner should show when a module needs calibration (FLEX only)Setup module for usebanner should show when either a fresh (not yet in deck config) Flex Stacker or Absorbance Plate Reader is attachedFirmware update availableshould show only when a setup flow is not required