Skip to content

Conversation

@jerader
Copy link
Collaborator

@jerader jerader commented May 19, 2025

…as labware

closes RQA-4140

Overview

Fixes up some bugs when adding a labware then going to add a module to the slot when the labware is compatible or incompatible

Test Plan and Hands on Testing

  • Add a NEST 96 well plate to the deck to slot B1, add a thermocycler and see that it adds correctly.
  • Delete the thermocycler, move the labware to slot A1. Add the thermocycler again and see that it errors
  • Move the labware to a different slot that is not A1 or B1. Move the tiprack to slot B1, add the thermocycler, see that it errors
  • Try other modules too and the trash bin/waste chute. see that it only successfully adds if there is no labware on the slot or the labware is compatible with the module.

Changelog

  • refactor logic
  • make utils and test

Risk assessment

low

@jerader jerader requested a review from a team as a code owner May 19, 2025 17:42
@jerader jerader requested review from koji and ncdiehl11 May 19, 2025 17:43
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 85.07463% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.02%. Comparing base (140735d) to head (97622a8).
Report is 22 commits behind head on edge.

Files with missing lines Patch % Lines
...organisms/HardwareConfigurator/AddFixtureModal.tsx 64.70% 6 Missing ⚠️
...rotocol-designer/src/components/organisms/utils.ts 91.66% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18390      +/-   ##
==========================================
- Coverage   58.04%   58.02%   -0.03%     
==========================================
  Files        3241     3247       +6     
  Lines      275215   276636    +1421     
  Branches    32211    32513     +302     
==========================================
+ Hits       159761   160519     +758     
- Misses     115261   115924     +663     
  Partials      193      193              
Flag Coverage Δ
protocol-designer 19.43% <85.07%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gner/src/components/organisms/FlexHardware/util.ts 78.96% <100.00%> (-0.14%) ⬇️
...rotocol-designer/src/components/organisms/utils.ts 55.17% <91.66%> (+10.56%) ⬆️
...organisms/HardwareConfigurator/AddFixtureModal.tsx 72.34% <64.70%> (-0.99%) ⬇️

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji
Copy link
Contributor

koji commented May 19, 2025

@jerader
for the 3rd case, is this an expected behavior? (when selecting A1)

tc.mov

@jerader
Copy link
Collaborator Author

jerader commented May 19, 2025

@jerader for the 3rd case, is this an expected behavior? (when selecting A1)

tc.mov

@koji good catch, this is a bug. will work on fixing it

@koji
Copy link
Contributor

koji commented May 21, 2025

still seeing the above issue when selecting A1 on sandbox.
never mind, the change hasn't been applied to sandbox because of s3 issue.

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as expected locally.
need to merge the workflow update to this branch

@jerader jerader merged commit 020899d into edge May 21, 2025
15 of 16 checks passed
@jerader jerader deleted the pd_edit-hw-labware branch May 21, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants