Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented May 23, 2025

Overview

add text to mix screen and add its test + fixtures
-most of the additionals are fixtures for test
fix typo repititions -> repetitions

close AUTH-1919

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

add text to mix screen and add its test

close AUTH-1919
@koji koji requested review from jerader and ncdiehl11 May 23, 2025 20:24
@koji koji marked this pull request as ready for review May 23, 2025 20:28
@koji koji requested review from a team as code owners May 23, 2025 20:28
@koji koji removed request for a team May 24, 2025 00:15
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (89b30fc) to head (5a64c90).
Report is 8 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 5 Missing ⚠️
...TransferFlow/QuickTransferAdvancedSettings/Mix.tsx 96.36% 2 Missing ⚠️
...erFlow/Aspirate/hooks/useAspirateSettingsConfig.ts 0.00% 1 Missing ⚠️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18428       +/-   ##
===========================================
+ Coverage   25.55%   58.00%   +32.45%     
===========================================
  Files        3254     3254               
  Lines      277250   277366      +116     
  Branches    32256    32353       +97     
===========================================
+ Hits        70848   160897    +90049     
+ Misses     206379   116274    -90105     
- Partials       23      195      +172     
Flag Coverage Δ
app 47.56% <85.93%> (+45.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ansferFlow/QuickTransferAdvancedSettings/index.tsx 87.82% <100.00%> (+87.82%) ⬆️
app/src/organisms/ODD/QuickTransferFlow/types.ts 100.00% <ø> (ø)
...erFlow/Aspirate/hooks/useAspirateSettingsConfig.ts 1.38% <0.00%> (+1.38%) ⬆️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 52.79% <0.00%> (+52.79%) ⬆️
...TransferFlow/QuickTransferAdvancedSettings/Mix.tsx 88.70% <96.36%> (+88.70%) ⬆️
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.76% <0.00%> (+0.76%) ⬆️

... and 1637 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Koji! Thanks for fixing the typo too.

@koji koji merged commit 4265cbc into edge May 27, 2025
32 checks passed
@koji koji deleted the feat_AUTH-1919 branch July 18, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants