Copy pipeline graph to temp dir to avoid whitespaces in path#472
Merged
Conversation
ebrahimebrahim
approved these changes
Jun 23, 2026
ebrahimebrahim
left a comment
Collaborator
There was a problem hiding this comment.
This looks great, thanks for the investigation to uncover what was going on!
fb7fda0 to
2d83351
Compare
2d83351 to
3587842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meshroom 2025.1.0 has a bug (alicevision/Meshroom#2808) where paths containing spaces are not properly quoted when
meshroom_computeis launched internally. This causesmeshroom_batchto fail with unrecognized arguments when the pipeline .mg file lives in a directory with spaces (e.g., OpenLIFU installation dir).Work around this by copying the pipeline file to the temp directory before passing it to meshroom_batch.
However, this is not a full guarantee if the temp directory itself contains spaces (i.e. if the username has spaces) - although this is usually not the case.