Reflect changes in libcurl error codes#115
Merged
kkaempf merged 1 commit intoOpenwsman:masterfrom Nov 16, 2018
vcrhonek:libcurl-error-codes
Merged
Reflect changes in libcurl error codes#115kkaempf merged 1 commit intoOpenwsman:masterfrom vcrhonek:libcurl-error-codes
kkaempf merged 1 commit intoOpenwsman:masterfrom
vcrhonek:libcurl-error-codes
Conversation
Collaborator
|
Thanks a million, Vitezslav ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Klaus,
openwsman fails to build with latest libcurl version (7.62.0). See [1] for more details. Curl error codes have been updated. CURLE_SSL_CACERT was deprecated (see [2]). Also quite long time ago CURLE_SSL_PEER_CERTIFICATE was renamed to CURLE_PEER_FAILED_VERIFICATION which is now unified error code for both. This commit fixes the compile error - leaves CURLE_SSL_PEER_CERTIFICATE and CURLE_SSL_CACERT for libcurl version < 7.62.0, uses CURLE_PEER_FAILED_VERIFICATION otherwise. You may probably want to check include/wsman-client-api.h whether anything has to be changed there... Feel free to modify/use the patch as you need.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1649393
[2] curl/curl@3f3b26d
[3] curl/curl@ce81cd2