Post-cutover cleanups to the back-end#286
Merged
AllenAnthes merged 5 commits intoOperationCode:masterfrom Mar 3, 2020
Merged
Conversation
Signed-off-by: Irving Popovetsky <irving@popovetsky.com>
Signed-off-by: Irving Popovetsky <irving@popovetsky.com>
…or else youll have a bad day trying to troubleshoot Signed-off-by: Irving Popovetsky <irving@popovetsky.com>
Signed-off-by: Irving Popovetsky <irving@popovetsky.com>
Signed-off-by: Irving Popovetsky <irving@popovetsky.com>
|
Code Climate has analyzed commit d1078d4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.4% (0.0% change). View more on Code Climate. |
kylemh
approved these changes
Mar 3, 2020
irvingpop
commented
Mar 3, 2020
| response_code = fields.get("response.status_code") | ||
|
|
||
| # never sample errors | ||
| if response_code and response_code >= 500: |
Collaborator
Author
There was a problem hiding this comment.
would it be better python to instead say:
if response_code is not None and response_code >= 500:?
Collaborator
Author
|
hey @AllenAnthes please merge if this looks good to you. had a style question about 1 line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Found a few annoyances, this PR cleans those up:
/healthz) and not store those tracesapi.operationcode.organd that's confusing peopleIssue Resolved
closes #282, closes #279, closes #271, closes #265, closes #255, closes #239, closes #231
Screenshots/GIFs