re-add the password host route #1080
Conversation
|
I replied in the backend, oops: |
| validatePasswordConfirm = value => value === '' || value === this.state.password; | ||
|
|
||
| handleOnClick = (e) => { | ||
| handleOnClick = e => { |
There was a problem hiding this comment.
Travis isn't liking this bit
./src/scenes/home/resetPassword/setPassword/setPassword.js
Line 34: Expected parentheses around arrow function argument having a body with curly braces arrow-parens
Search for the keywords to learn more about each error.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [build_site] Error 1
|
Fixed the things, added Also added a password change route at |
| }) | ||
| .catch(() => { | ||
| .catch((err) => { | ||
| Raven.setUserContext({ |
There was a problem hiding this comment.
this shouldn't actually be necessary, as raven catches all exceptions, but i'll leave it cuz maybe context is helpful
There was a problem hiding this comment.
Context was the only reason I put this in here.
| this.setState({ success: true, error: null }); | ||
| }) | ||
| .catch(() => { | ||
| this.setState({ error: 'We were unable to set the password for this email' }); |
There was a problem hiding this comment.
Maybe we should add next steps in this message, such as: "please email staff@operationcode.org for help"
There was a problem hiding this comment.
I think the toasts are fairly small, and this is a big amount of text, what would you recommend?
There was a problem hiding this comment.
Just the next steps then. It will be red indicating a failure. It's not accessible, but in terms of getting a message across, let's just say to email us.
Also, is the toaster fixed height? I would hope that would expand to fit content.
3 participants
Includes the route to the backend without the api
Will still need to add the environment variable for this in k8s.