Skip to content

Force redirect of HTTP to HTTPS#149

Merged
irvingpop merged 2 commits intomasterfrom
redirect-https
May 3, 2020
Merged

Force redirect of HTTP to HTTPS#149
irvingpop merged 2 commits intomasterfrom
redirect-https

Conversation

@aaron-junot
Copy link
Copy Markdown
Member

@aaron-junot aaron-junot commented May 1, 2020

I don't like that when you visit http://resources.operationcode.org it doesn't automatically redirect you to https://resources.operationcode.org

I hope this fixes that? I'm not super confident. Please advise

@aaron-junot aaron-junot requested a review from irvingpop May 1, 2020 03:06
apex-omontgomery
apex-omontgomery approved these changes May 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@apex-omontgomery apex-omontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot

Fix whitespace for redirect rule and remove example rules. validated …
76eb0a7 
…working in staging

Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
@irvingpop
Copy link
Copy Markdown
Collaborator

irvingpop commented May 3, 2020

had to make a couple of changes, removing the example rules (we have no user-service) and also fixed the whitespace. tested, working in staging. pushing to your branch and merging.

$ curl -kv http://backend-staging.k8s.operationcode.org/
*   Trying 3.136.202.192...
* TCP_NODELAY set
* Connected to backend-staging.k8s.operationcode.org (3.136.202.192) port 80 (#0)
> GET / HTTP/1.1
> Host: backend-staging.k8s.operationcode.org
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 301 Moved Permanently
< Server: awselb/2.0
< Date: Sun, 03 May 2020 16:40:01 GMT
< Content-Type: text/html
< Content-Length: 150
< Connection: keep-alive
< Location: https://backend-staging.k8s.operationcode.org:443/
<
<html>
<head><title>301 Moved Permanently</title></head>
<body bgcolor="white">
<center><h1>301 Moved Permanently</h1></center>
</body>
</html>
* Connection #0 to host backend-staging.k8s.operationcode.org left intact
* Closing connection 0

@irvingpop irvingpop merged commit 10798ba into master May 3, 2020
@aaron-junot aaron-junot deleted the redirect-https branch May 9, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apex-omontgomery apex-omontgomery apex-omontgomery approved these changes

@irvingpop irvingpop Awaiting requested review from irvingpop

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaron-junot @irvingpop @apex-omontgomery