Redirect /metrics and /healthz to root in staging#153
Merged
projectLewis merged 2 commits intomasterfrom May 9, 2020
Merged
Conversation
projectLewis
reviewed
May 9, 2020
projectLewis
approved these changes
May 9, 2020
Collaborator
projectLewis
left a comment
projectLewis
left a comment
There was a problem hiding this comment.
Verified this change is under the staging directory, and previous comment has been updated.
Member
Author
|
After merge, it appears this did not work as I can still hit https://resources.staging.operationcode.org/healthz and https://resources.staging.operationcode.org/metrics and I don't get redirected to https://resources.staging.operationcode.org/ I'm not sure what to try next, but we'll have to do something |
Member
Author
|
It's very possible that this is just not supported https://www.reddit.com/r/aws/comments/73u365/alb_does_not_support_path_rewriting/ |
Collaborator
|
The AWS blog says its not supported and suggests using Nginx or a network load balancer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this will work, but I suspect it will. The goal is to make the
/metricsand/healthzendpoints only available within the cluster. If someone attempts to access them from outside the cluster, they'll be redirected to/instead.If this works in staging, I'll follow up with another PR to update production.