Verify ArgoCD works with "main" branch#162
Merged
aaron-junot merged 1 commit intomainfrom Jul 6, 2020
Merged
Conversation
Collaborator
Author
|
closed, circleci needs to be updated first |
aaron-junot
approved these changes
Jul 6, 2020
Member
aaron-junot
left a comment
aaron-junot
left a comment
There was a problem hiding this comment.
👍 , we should probably be denying requests to /faketestdestination anyway.. no one is authorized for that 😆
aaron-junot
pushed a commit
that referenced
this pull request
Jul 6, 2020
This reverts commit 06cb6f4.
projectLewis
pushed a commit
that referenced
this pull request
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a pointless change to an endpoint in
resources-stagingto return a 401 if someone tries to go to the/faketestdestinationendpoint. If argocd syncs as expected I will remove this change.