Add DNS record for pybot subdomain#93
Merged
ohaiwalt merged 1 commit intoOperationCode:masterfrom May 17, 2019
AllenAnthes:AllenAnthes/add-pybot-subdomain
Merged
Add DNS record for pybot subdomain#93ohaiwalt merged 1 commit intoOperationCode:masterfrom AllenAnthes:AllenAnthes/add-pybot-subdomain
ohaiwalt merged 1 commit intoOperationCode:masterfrom
AllenAnthes:AllenAnthes/add-pybot-subdomain
Conversation
ohaiwalt
reviewed
May 17, 2019
| type = "string" | ||
| } | ||
|
|
||
| variable "pybot-lb-ingress" { |
Member
There was a problem hiding this comment.
Fair to put this in a var, but not particularly necessary unless you intend to reuse it multiple times. The k8s cluster address is made into a variable in this instance because it's the CNAME record for every externally accessible service in our cluster.
Member
Author
There was a problem hiding this comment.
It'll be used for the staging environment as well, I just wanted to get this up to date first.
Also, just figured it kept everything cleaner.
ohaiwalt
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the previously created DNS record for the pybot.operationcode.org subdomain to terra, as well as associated ingress url variable