Skip to content

Initial configs for adding django BE to cluster#97

Merged
ohaiwalt merged 1 commit intoOperationCode:masterfrom
AllenAnthes:AllenAnthes/add-new-be
May 26, 2019
Merged

Initial configs for adding django BE to cluster#97
ohaiwalt merged 1 commit intoOperationCode:masterfrom
AllenAnthes:AllenAnthes/add-new-be

Conversation

@AllenAnthes
Copy link
Member

No description provided.

Copy link
Member

@ohaiwalt ohaiwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some comments

- name: DB_HOST
value: # TODO
- name: ENVIRONMENT
value: aws_prod No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the significance of this aws_prod vs prod?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a hacky way to tell django to use the aws_s3 bucket to serve static assets, while still allowing me to run the production config locally sans remote static files

http:
paths:
- backend:
serviceName: operationcode-backend-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be back-end-service if you want to receive traffic. However, we'll likely want to hold off on that or put this up on an alternate URL for testing until it works

@ohaiwalt ohaiwalt merged commit 0042f17 into OperationCode:master May 26, 2019
spec:
containers:
- name: app
image: operationcode/back-end:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you currently have a dockerhub repo setup for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cloud.docker.com/repository/registry-1.docker.io/operationcode/back-end

You do now. Need to get credentials in circle ci to handle it.

- name: app
env:
- name: DB_HOST
value: # TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use terraform for provisioning this or do you need help setting it up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's TODO because we need to wait until the last minute to snapshot the current prod before going live

- name: DB_HOST
value: # TODO
- name: ENVIRONMENT
value: aws_prod No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this aws_prod and not just production?

Copy link
Member Author

@AllenAnthes AllenAnthes May 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from above

It's a hacky way to tell django to use the aws_s3 bucket to serve static assets, while still allowing me to run the production config locally sans remote static files

http:
paths:
- backend:
serviceName: operationcode-backend-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this need to match the new service name?

@AllenAnthes AllenAnthes deleted the AllenAnthes/add-new-be branch May 27, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants