fix(env_manager): Use base64 encoding for robust .env file content wr…#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way environment files are created and written to, improving security and reliability. The main change is switching from direct shell commands to using a base64-encoded approach for writing
.envfiles, which avoids issues with special characters and ensures proper file permissions. The implementation now uses a helper function,run_command, for executing remote commands, and the corresponding unit tests have been updated to mock this new behavior.Environment file creation improvements:
create_env_fileinsrc/env_manager.pyto use base64 encoding andteefor writing environment variables to files, preventing shell character and newline mangling issues, and to set secure file permissions (chmod 600). The function now usesrun_commandfor all remote operations instead of callingconn.rundirectly.src/env_manager.pyto includebase64andrun_commandfor the new implementation. [1] [2]Testing updates:
test_heredoc_escapingunit test intests/unit/test_env_manager.pyto mockrun_commandinstead ofconn.run, and to check for the correct base64-encoded content and usage ofteeandbase64 -din the command.…iting