Skip to content

overhaul contributing based on feedback from evan#393

Merged
rocktavious merged 4 commits intofeature/mcpfrom
kr/contrib
Apr 16, 2025
Merged

overhaul contributing based on feedback from evan#393
rocktavious merged 4 commits intofeature/mcpfrom
kr/contrib

Conversation

@rocktavious
Copy link
Collaborator

Resolves #

Problem

The CONTRIBUTING.md was too high level and beginner friendly for more experianced devs. Additionally the document hadn't really been touched since the inception of the CLI

Solution

Rewrite the document for more internal use while still being relevant for external contributors. Add more information around the project architecture, how to get started, what helpers have been added to the repo and generally just have a better flow / structure.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious self-assigned this Apr 16, 2025
Copy link
Contributor

@eapache-opslevel eapache-opslevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits/questions. The only other high-level thing (that I know of) that's missing is a mention of long-running branches in the development workflow?

But already this is a big help, thank you.

Copy link
Collaborator Author

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review feedback

@rocktavious rocktavious merged commit 83f068a into feature/mcp Apr 16, 2025
1 check passed
@rocktavious rocktavious deleted the kr/contrib branch April 16, 2025 19:38
@rocktavious rocktavious restored the kr/contrib branch April 21, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants