Add connection pools #272
Merged
Add connection pools #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonopslevel
commented
Jan 19, 2026
| } | ||
| } else { | ||
| err := s.client.Push(job) | ||
| err := s.helper.With(func(cl *faktory.Client) error { |
Contributor
Author
There was a problem hiding this comment.
The go faktory worker creates a connection pool already! We just needed to use it.
jasonopslevel
commented
Jan 19, 2026
| config, _ := GetKubernetesConfig() | ||
| client, _ := GetKubernetesClientset() | ||
| // kubernetes.Clientset is thread-safe and designed to be shared across goroutines | ||
| config, client, _ := GetSharedK8sClient() // Already validated by LoadK8SClient |
Contributor
Author
There was a problem hiding this comment.
The removed comments were in general right about sharing clients. The client is threadsafe, however we just need some synchronization around initializing it, as we load the k8s client per NewJobRunner.
We don't manipulate the data from the clients at all so this should be fine.
jasonopslevel
force-pushed
the
add-connection-pools
branch
from
c6446b8 to
031d94d
Compare
derek-etherton-opslevel
approved these changes
Jan 19, 2026
| } | ||
| } else { | ||
| err := s.client.Push(job) | ||
| err := s.helper.With(func(cl *faktory.Client) error { |
| k8sClientOnce.Do(func() { | ||
| sharedK8sConfig, k8sInitError = GetKubernetesConfig() | ||
| if k8sInitError != nil { | ||
| return |
Contributor
There was a problem hiding this comment.
Suggested change
| return | |
| return nil, nil, k8sInitError |
Contributor
Author
There was a problem hiding this comment.
this return is for the anonymous function from Do() - so i think the empty return is correct here.
| if k8sInitError != nil { | ||
| return nil, nil, k8sInitError | ||
| } | ||
| if _, err := GetKubernetesClientset(); err != nil { |
Contributor
There was a problem hiding this comment.
this method is no longer used if we wanna 🔪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
We have an issue where we're using a faktory go worker manager, but not using the connection pool. So we create N connections and hold on to them, but then also open new connection ad-hoc. This is the reason we've bumped into connection limit errors.
Demo:
Running the old + new side by side, we have a stable N + 1 connections, vs uncapped essentially.
Work done:
K8s Connection Pooling (src/pkg/k8s.go)
Faktory Connection Pooling
src/pkg/faktoryRunnerAppendJobLogProcessor.go:
src/pkg/faktorySetOutcomeProcessor.go:
Changelog
changieentryTophatting