Skip to content

OP-22308: Adding VerifyApplicationHasNoDependenciesTask class to deleteApplication task. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudhakaropsmx merged 1 commit into from
Jul 31, 2024
Merged

OP-22308: Adding VerifyApplicationHasNoDependenciesTask class to deleteApplication task. #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...custom-stage-orca/src/main/java/com/opsmx/plugin/stage/custom/DeleteApplicationStage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import javax.validation.constraints.NotNull;

import com.netflix.spinnaker.orca.applications.tasks.VerifyApplicationHasNoDependenciesTask;
import org.pf4j.Extension;
import org.springframework.stereotype.Component;

Expand All @@ -21,6 +22,7 @@ public class DeleteApplicationStage implements StageDefinitionBuilder {
public void taskGraph(@NotNull StageExecution stage, @NotNull TaskNode.Builder builder) {

builder.withTask("validateApplication", RBACValidationTask.class)
.withTask("verifyNoDependencies", VerifyApplicationHasNoDependenciesTask.class)
.withTask("deleteTask", DeleteApplicationTask.class);
}
}
4 changes: 3 additions & 1 deletion rbac/custom-stage-orca/src/main/java/com/opsmx/plugin/stage/custom/RBACValidationTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,10 @@ public TaskResult execute(StageExecution stage) {

if (stage.getType().equalsIgnoreCase("CreateApplication")) {
finalInput = getOpaInput(application, "createApp", groupList, stage.getExecution().getAuthentication().getUser());
} else {
} else if (stage.getType().equalsIgnoreCase("UpdateApplication")){
finalInput = getOpaInput(application, "updateApp", groupList, stage.getExecution().getAuthentication().getUser());
} else {
finalInput = getOpaInput(application, "deleteApp", groupList, stage.getExecution().getAuthentication().getUser());
}


Expand Down