Possible fix for disposal of sequence#824
Merged
JuliusSweetland merged 1 commit intoOptiKey:masterfrom Mar 31, 2022
Merged
Conversation
We require sequence to be set to null when terminated, otherwise it doesn't get re-set up when the point source is swapped out.
kmcnaught
force-pushed
the
feature/manualmodeFix
branch
from
767ffe1 to
50008c3
Compare
Collaborator
Author
|
Fix now applied to three trigger sources that follow the same pattern / exhibit the same bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might fix #524, explanation in issue thread. If approved, I neef to make the same change to other trigger sources