Skip to content

Move configuration into package#16

Merged
OrF8 merged 2 commits into
cleanup/reorganize-codebasefrom
cleanup/move-config-into-package
Jun 28, 2026
Merged

Move configuration into package#16
OrF8 merged 2 commits into
cleanup/reorganize-codebasefrom
cleanup/move-config-into-package

Conversation

@OrF8

@OrF8 OrF8 commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • moves the root-level Constants.py module to statoverflow/config.py
  • updates production modules, tests, and notebook imports to use statoverflow.config
  • preserves every constant value and repository-relative data/result path
  • removes the obsolete root-level configuration module without adding a compatibility shim
  • validates all tracked source and notebook code against the Python 3.9 grammar

Python compatibility

  • local validation environment: Python 3.12.10
  • supported project baseline: Python 3.9
  • pyproject.toml remains requires-python = ">=3.9"
  • Python 3.10-only annotation syntax was replaced only where required
  • no scientific result was regenerated or claimed under Python 3.12

Configuration migration

  • statoverflow/config.py is now the canonical configuration module
  • BASE_DIR continues to resolve to the repository root
  • all derived data, preprocessing, analysis, and cached-output paths are unchanged
  • importing configuration performs no filesystem writes
  • active code contains no remaining Constants imports

Packaging status

  • setuptools package discovery remains disabled
  • this PR does not make the source package installable
  • editable source installation is deferred to a separate stage

Validation

  • created or reused a local Python 3.12 virtual environment
  • ran the complete unittest suite
  • compared every exported uppercase configuration value before and after
  • verified all resolved paths are identical
  • verified imports from the repository root and an external working directory
  • parsed all tracked Python files with the Python 3.9 grammar
  • parsed every notebook code cell with the Python 3.9 grammar
  • compiled all Python files with Python 3.12
  • validated all five notebooks as JSON
  • executed only notebook import/orchestration cells
  • confirmed no active Constants imports remain
  • confirmed pyproject.toml and requirements.txt are unchanged
  • confirmed no data or result files changed
  • did not run any real analysis

@OrF8 OrF8 self-assigned this Jun 28, 2026
@OrF8 OrF8 marked this pull request as ready for review June 28, 2026 09:12
@OrF8 OrF8 requested a review from noam-kimhi as a code owner June 28, 2026 09:12
@OrF8 OrF8 merged commit ebf51b1 into cleanup/reorganize-codebase Jun 28, 2026
3 checks passed
@OrF8 OrF8 deleted the cleanup/move-config-into-package branch June 28, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant