This repository was archived by the owner on Oct 20, 2022. It is now read-only.
Improve error handling on bytes error#11
Closed
bwidtmann wants to merge 3 commits into
Closed
Conversation
…or + restrict ABR controller to not switch to unavailable quality level(s) for a while (10s)
…uffer instead of loadInitialization)
|
Thanks for this PR. We will have a look, try it and provide you a feedback as soon as possible.
|
Author
|
I could restart with highest quality, if we reach lowest quality and is not available. So in case of lost internet connection, it would be a loop through all quality levels until one is available again. I know the abrController.setAutoSwitchBitrate(), but I do not want to switch it off in case of not available quality level. Yes, I will rename it to BufferController.onErrorABRDisableInterval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of lost internet connection, corrupted or not available chunks on the CDN currently playback stops. This PR changes the behavior to switch to lower quality level and NOT stop scheduler in case of bytes error.
Additionally restrict ABR controller to not switch to unavailable quality level(s) for a certain time (configurable). (line 648 - 669) I know changing configuration at runtime is not a smart way but this was a clean way without changing a lot of files.