Fix JavaScript injection in HTML report through regex literal #4113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamiel
changed the title
jcamiel
force-pushed
the
visitor
branch
2 times, most recently
from
6a8252a to
e8b173f
Compare
jcamiel
force-pushed
the
visitor
branch
2 times, most recently
from
5249ad8 to
c4b5a99
Compare
The HTML report generation uses a new AST walker.
Collaborator
|
/accept |
Collaborator
|
🕗 /accept is running, please wait for completion. |
Collaborator
|
✅ Pull request merged with fast forward by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabricereix I've changed the implementation of HTML format: was not mandatory to fix the injection pb but I think we could share the "walking" AST part for HTML and text export.
Now, we have a visitor trait with each node having a corresponding
visit_itemmethod.. Caller can insert custom code invisit_item, stop the walking or resume by callingwalk_item.Code is borrowed from rustc => https://github.com/rust-lang/rust/blob/master/compiler/rustc_ast/src/visit.rs
The text export (with ANSI code etc...) has not been touched. To test for regression, I've exported into HTML all our integration Hurl files and test the export before and the new export.
If you're OK with the code, let's merge it!