Skip to content

python/vehicle: hot-fix for OpenTelemetry authentication#180

Merged
ymorin-orange merged 1 commit intoOrange-OpenSource:masterfrom
ymorin-orange:nyma/vehicle-otel-auth
Oct 21, 2024
Merged

python/vehicle: hot-fix for OpenTelemetry authentication#180
ymorin-orange merged 1 commit intoOrange-OpenSource:masterfrom
ymorin-orange:nyma/vehicle-otel-auth

Conversation

@ymorin-orange
Copy link
Member

Bug-fix:

  • Workaround authentication in its-vehicle

**How to test:

  1. Start an OpenTelemetry collector with Basic Auth.
  2. Install its-vehicle
  3. Enable telemetry in its-vehicle:
    [telemetry]
    endpoint = http://your-otlp-collector:4318
    username = USER
    password = PASSWD
  4. Look at the traces in your OTLP collector

Expected results:

The its-vehicle traces appear in the OTLP collector.

@ymorin-orange ymorin-orange added the Python Python code label Oct 21, 2024
@ymorin-orange ymorin-orange added this to the Sprint 3 milestone Oct 21, 2024
@ymorin-orange ymorin-orange requested a review from tigroo October 21, 2024 10:51
@ymorin-orange ymorin-orange self-assigned this Oct 21, 2024
Copy link
Collaborator

@tigroo tigroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested together, ok.

The OpenTelemetry client needs to be given the type of authentication;
or it would default to non authentication.

In practice, its-vehicle will alwyas use some authentication; for now,
we only need BasicAuth.

Quick host-fix by hard-coding the use of BasicAuth, while waiting for a
proper solution in the future.

Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
@ymorin-orange ymorin-orange force-pushed the nyma/vehicle-otel-auth branch from 641f285 to 863ecb5 Compare October 21, 2024 10:53
@ymorin-orange ymorin-orange merged commit ca8f3dc into Orange-OpenSource:master Oct 21, 2024
@ymorin-orange ymorin-orange deleted the nyma/vehicle-otel-auth branch October 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Python Python code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants