Skip to content

fix: correct minor typos in docs and Swift files#84

Merged
pylapp merged 1 commit intoOrange-OpenSource:89-doc-integrate-fixes-of-typofrom
julien-deramond:develop-jd-fix-some-typos
Sep 10, 2024
Merged

fix: correct minor typos in docs and Swift files#84
pylapp merged 1 commit intoOrange-OpenSource:89-doc-integrate-fixes-of-typofrom
julien-deramond:develop-jd-fix-some-typos

Conversation

@julien-deramond
Copy link
Copy Markdown
Contributor

@julien-deramond julien-deramond commented Sep 9, 2024

Related issues

N/A

Description

This PR simply suggests fixing some typos in the DEVELOP.md file, but also in some Swift files I was analyzing for the Style Dictionary work.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

N/A

Checklist

Contribution

Accessibility

  • (N/A) My change follows accessibility good practices

Design

  • (N/A) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • (N/A) I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (N/A) Design review has been done
  • (N/A) Accessibiltiy review has been done
  • (N/A) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

Signed-off-by: Julien Déramond <julien.deramond@orange.com>
Comment thread OUDS/Core/Tokens/RawTokens/Sources/BorderRawTokens.swift
@pylapp pylapp self-assigned this Sep 10, 2024
@pylapp pylapp changed the base branch from develop to 89-doc-integrate-fixes-of-typo September 10, 2024 08:26
Copy link
Copy Markdown
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp pylapp merged commit e2b1a3d into Orange-OpenSource:89-doc-integrate-fixes-of-typo Sep 10, 2024
@julien-deramond julien-deramond deleted the develop-jd-fix-some-typos branch September 10, 2024 08:43
pylapp pushed a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants