Allow files with space in filename #42
Conversation
Pierstoval
left a comment
Pierstoval
left a comment
There was a problem hiding this comment.
I made some suggestions for you. If you could remove the trim part, the gitignore, and replace your quotes concatenation with escapeshellarg() I'll merge it directly :)
.gitignore
Outdated
| ImageMagick*.tar.gz | ||
| /ImageMagick-*/ | ||
|
|
||
| .idea |
There was a problem hiding this comment.
This should not be versioned. Instead, you can use a global ignore file.
Example of command to create such file:
git config --global core.excludesfile ~/.gitignore
touch ~/.gitignore
echo ".idea" >> .gitignore
This will create a global ignore file that you can use to remove all unnecessary files from Git, like .DS_STORE (for macs), or thumbs.db for Windows, etc.
There was a problem hiding this comment.
Thanks for that tip :)
src/Command.php
Outdated
| $path = \rtrim($path, '/'); | ||
| } | ||
|
|
||
| $path = \trim($path, '"'); |
There was a problem hiding this comment.
There is a flag argument to check whether to trim the value or not, reasons where inconsistent path checks. Adding trim() here makes the arg useless, while it is useful not to trim sometimes.
src/Command.php
Outdated
| } | ||
|
|
||
| $path = \trim($path, '"'); | ||
| $path = '"' . $path . '"'; |
There was a problem hiding this comment.
For shell commands, PHP already has a function for that, called escapeshellarg()
|
Thanks @jonasschmidt95 👍 |
2 participants
Wrap file path in quotes to allow files with spaces