Bugfix/menu flyout#663
Merged
datdamnzotz merged 6 commits intoOrcpub:developfrom Apr 9, 2026
Merged
Conversation
…focus Each header tab had its own Reagent atom controlling flyout visibility. On mobile, opening one tab couldn't close another since atoms were independent. Also no way to dismiss by tapping outside. Replace with CSS :hover (desktop) and :focus-within (mobile tap). Focus is inherently exclusive — opening one tab blurs the previous. Tapping outside naturally blurs, closing all flyouts. - Remove per-tab hovered? atoms from header-tab and header-tab2 - Add .header-flyout CSS class: hidden by default, shown on :hover/:focus-within - Add tabindex=0 for focusability, mousedown handler for tap-to-toggle - Flyout items call .blur() on click to dismiss after navigation
Adjacent header-tab elements create competing stacking contexts via position:relative, causing their SVG icons to paint over the dropdown. Elevate the hovered/focused tab's z-index above siblings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan